Tweak docs for Flex #8571
Merged
Tweak docs for Flex #8571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatomefi
reviewed
Nov 1, 2017
| by default, but it will still be optional to use. | ||
| as installing and removing bundles and other Composer dependencies. Symfony | ||
| Flex works for Symfony 3.3 and newer versions. Starting from Symfony 4.0, Flex | ||
| should be used by default, but it is optional to use. |
There was a problem hiding this comment.
should be used by default, but it is optional to use.
I'd say:
should be used by default, but it is still optional.
To to avoid the double "used/use"
| SwiftmailerBundle and returns the "recipe" for it. | ||
|
|
||
| Flex keeps tracks of which recipes it installed in a ``symfony.lock`` file that | ||
| must be committed in your code repository. |
There was a problem hiding this comment.
I'd rewrite to:
Flex keeps tracks of installed recipes in a ``symfony.lock`` file which must be committed in your code repository.
Just for better concordance
| Symfony Flex as a dependency, so you can create a new Flex-enabled Symfony | ||
| application executing the following command: | ||
| project recommended to create new applications. This "skeleton" already | ||
| includes Symfony Flex as a dependency, so you can create a new Flex-enabled |
There was a problem hiding this comment.
, so you can create a new
to
, thus you can create a new
jaikdean
reviewed
Nov 1, 2017
| and directory created by this recipe. | ||
| remember names (``composer require mailer`` vs ``composer require | ||
| symfony/swiftmailer-bundle``). The ``bundles`` option tells Flex in which | ||
| environments should this bundle be enabled automatically (``all`` in this |
There was a problem hiding this comment.
environments should this bundle be enabled automatically should be environments this bundle should be automatically enabled
weaverryan
added a commit
that referenced
this pull request
Nov 2, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Tweak docs for Flex I added a sentence about the new `symfony.lock` file and did some minor adjustments. Commits ------- 6d0d8f5 tweaked docs for Flex
weaverryan
added a commit
that referenced
this pull request
Nov 2, 2017
|
Thanks for the review! I've made the suggested changes and merged :) |
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2017
* 3.3: more underlining! [#8571] Tweaks thanks to reviewers tweaked docs for Flex Update security.rst use .test instead of .dev as development domain Shortened command... easier to remember ;) Final updates Last fixes Restored the "Full Default Configuration" dump Fixed an indentation issue Simplified the framework configuration reference Added Doctrine entities and documents to the list of known locations for classes
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2017
* 3.4: more underlining! [#8571] Tweaks thanks to reviewers tweaked docs for Flex Update security.rst use .test instead of .dev as development domain updating controller scalar args for 3.4 Shortened command... easier to remember ;) Final updates Last fixes Restored the "Full Default Configuration" dump Fixed an indentation issue Simplified the framework configuration reference Added Doctrine entities and documents to the list of known locations for classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a sentence about the new
symfony.lockfile and did some minor adjustments.